Page MenuHomePhabricator

Flagged Revs rights weirdness
Closed, DeclinedPublic

Description

About the Editor and Reviewer groups. the config shows this:

$wgGroupPermissions['reviewer']['validate'] = true;
$wgGroupPermissions['reviewer']['review'] = true;
$wgGroupPermissions['reviewer']['autoreview'] = true;
$wgGroupPermissions['reviewer']['autoconfirmed'] = true;
$wgGroupPermissions['reviewer']['editsemiprotected'] = true;
$wgGroupPermissions['reviewer']['unreviewedpages'] = true;
$wgGroupPermissions['editor']['review'] = true;
$wgGroupPermissions['editor']['autoreview'] = true;
$wgGroupPermissions['editor']['autoconfirmed'] = true;
$wgGroupPermissions['editor']['editsemiprotected'] = true;
$wgGroupPermissions['editor']['unreviewedpages'] = true;

Go to https://testwiki.wiki/wiki/Special:ListGroupRights you will see it does not match.
I added the above to the config in a resent PR but it is copied from the plugin itself.
Maybe the plugin needs to be updated or something?

Details

Security
None

Event Timeline

Bonnedav created this task.Sep 10 2018, 3:12 AM
Void triaged this task as Normal priority.Sep 10 2018, 3:54 AM
Void added a subscriber: Void.

I figured it out. it is because of this code in the extension.

public static function setConditionalRights() {
		global $wgGroupPermissions, $wgFlaggedRevsProtection;
		if ( $wgFlaggedRevsProtection ) {
			// XXX: Removes sp:ListGroupRights cruft
			if ( isset( $wgGroupPermissions['editor'] ) ) {
				unset( $wgGroupPermissions['editor']['unreviewedpages'] );
			}
			if ( isset( $wgGroupPermissions['reviewer'] ) ) {
				unset( $wgGroupPermissions['reviewer']['unreviewedpages'] );
				unset( $wgGroupPermissions['reviewer']['validate'] );
			}
		}
	}

This automatically removes the unreviewedpages and validate rights from editor and reviewer when $wgFlaggedRevsProtection is true.
I don't know why it does this, but I would suggest setting $wgFlaggedRevsProtection to false is it seams to disable some functions.

Accualy , it seems to be becuese $wgFlaggedRevsProtection is considered some sort of "simple mode" or "simple config" of the extension.
I suggest setting it false to enable full functionality of the Flagged Revs extension.

After unsetting that config you can remove the editor and reviewer rights grants from the config as they are the same as the extension's defaults.

Void added a comment.Sep 15 2018, 11:14 PM

TBH, I'm not sure we really want/need to change it. Unless there is some sort of need for testing that particular toolset.

This is a non-default option that makes flagged revs work only as a protection system. It is not a common setup and disables a lot of functionality. Would it not be best to allow testing with the most common/default configuration. We already have a protection system that works just fine, with this enabled I think that there is almost no point to having Flagged Revs installed at all. Please disable this so we can test the full/default functionality of the extension.

MacFan4000 closed this task as Declined.Nov 30 2018, 5:26 PM
MacFan4000 claimed this task.

I’d rather not have flagged Rex’s on the entire site, just in protection mode is what I prefer.