Page MenuHomePhabricator

Regression with MatomoAnalytics extension
Closed, ResolvedPublic

Description

I found today that MatomoAnalytics wasn’t working. This was due to an issue where if $wg MatomoAnalyticsGlobalID wasn’t defined in LocalSettings.php, in the tracking js, you would have the following line
var globalid = ;
This is invalid JS. This was fixed in https://github.com/miraheze/MatomoAnalytics/commit/f50dd987226313d65b3d3ff03b409123b86feafc but it’s broken again in the newest version. This should probably be reported upstream. I have put a temp fix in LocalSettings.php

Details

Security
None

Event Timeline

MacFan4000 triaged this task as Normal priority.Mar 25 2020, 2:57 AM
MacFan4000 created this task.
MacFan4000 claimed this task.