Page MenuHomePhorge
Files F585131

No OneTemporary
Actions

Size
2 KB
Referenced Files
None
Subscribers
None

View Options

diff --git a/RELEASE-NOTES-1.44 b/RELEASE-NOTES-1.44
index e508e5cb854..ec6473f1e78 100644
--- a/RELEASE-NOTES-1.44
+++ b/RELEASE-NOTES-1.44
@@ -648,7 +648,7 @@ because of Phabricator reports.
since toolbox relates to tools associated with the current page, not the
site. To support the transition, for interface admins who have already
customized MediaWiki:Sidebar, the special pages link will be automatically
- added. This will start emitting notices in the next MediaWiki release. More
+ added. This will emit deprecation warning. More
information is available at T333211. To avoid future breakage, see the
guidance in T385346.
* Various deprecated static methods of Xml, deprecated in earlier versions, are
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index f81f6afe4e2..069667df720 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -1553,6 +1553,7 @@ abstract class Skin extends ContextSource {
if ( !$isSpecialPagesPresent ) {
$item = $this->createSidebarItem( 'specialpages-url', 'specialpages' );
if ( $item !== null ) {
+ wfDeprecated( __METHOD__, '1.44' );
$this->sidebar['navigation'][] = $item;
}
}
diff --git a/tests/phpunit/includes/skins/SkinTest.php b/tests/phpunit/includes/skins/SkinTest.php
index 871005860c7..e6c7a433641 100644
--- a/tests/phpunit/includes/skins/SkinTest.php
+++ b/tests/phpunit/includes/skins/SkinTest.php
@@ -621,6 +621,7 @@ class SkinTest extends MediaWikiIntegrationTestCase {
** recentchanges-url|recentchanges
** randompage-url|randompage
** helppage|help-mediawiki
+ ** specialpages-url|specialpages
* SEARCH
* TOOLBOX
** A|B
@@ -631,7 +632,6 @@ class SkinTest extends MediaWikiIntegrationTestCase {
$context = RequestContext::newExtraneousContext( Title::makeTitle( NS_MAIN, 'Main Page' ) );
$foo1->setContext( $context );
- $this->assertArrayContains( [ 'id' => 'n-specialpages' ], end( $foo1->buildSidebar()['navigation'] ), 'Navigation sidebar automatically appends link to special pages' );
$this->assertArrayContains( [ [ 'id' => 'n-B', 'text' => 'B' ] ], $foo1->buildSidebar()['TOOLBOX'], 'Toolbox has user defined links' );
$hasUserDefinedLinks = false;

File Metadata

Mime Type
text/x-diff
Expires
Sat, Jul 5, 5:32 AM (18 h, 15 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
227549
Default Alt Text
(2 KB)

Event Timeline