HomePhorge

moveToExternal: Also check for utf8 encoding before trying to convert

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

moveToExternal: Also check for utf8 encoding before trying to convert

While most rows in production use 'utf-8' to flag content being UTF-8,
we have lots of rows flagged with 'utf8':
mysql:research@s3-analytics-replica.eqiad.wmnet [dawiki]> select old_flags, count(*) from text group by old_flags limit 50;
+---------------------+----------+

old_flagscount(*)

+---------------------+----------+

error2
external,gzip49
external,object36
external,utf-81614469
external,utf8336780
gzip,utf-8,external1094
utf-8,gzip,external9458083

+---------------------+----------+
7 rows in set (26.038 sec)

This would confuse the script to try to reencode it again which possibly
could lead to all sorts of errors

Change-Id: I9b4a38538199c9954cfed51cdd2bba8b0f6cb953
(cherry picked from commit 4dd3850bebdd972001a007f1bcc5a127d3d4dc4f)

Details

Provenance
Amir Sarabadani <ladsgroup@gmail.com>Authored on Jun 8 2023, 12:20 PM
Zabe <zabe@avorwerk.net>Committed on Jun 9 2023, 10:27 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.