HomePhorge

LinksUpdate: Use DB key for category links table

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

LinksUpdate: Use DB key for category links table

The first parameter returned from findVariantLink() is not the DB key,
which whitespaces should be replaced with underscores.

Also:

  1. Replaced Title::makeTitleSafe with Title::makeTitle, invalid links would be treated as plain text by the parser and can never hit this code path. And the makeTitle function below is also using Title::makeTitle.
  2. Updated the document of findVariantLink().

Reason for backport: The bug was introduced by refactor (commit d3b2b80)
and I found this is annoying in production.

Bug: T328477
Change-Id: I2b08edd90666e0fa4eafe91444a58806909b02d6
(cherry picked from commit 1132c3dc19bfa0604c5605340c1dd11587d05789)

Details

Provenance
Func <Funcer@outlook.com>Authored on Jan 31 2023, 6:11 PM

Event Timeline

Func <Funcer@outlook.com> committed rMWb4420b3ba693: LinksUpdate: Use DB key for category links table (authored by Func <Funcer@outlook.com>).Feb 22 2023, 10:04 AM

Commit No Longer Exists

This commit no longer exists in the repository.