Page MenuHomePhorge
Files F585069

No OneTemporary
Actions

Size
1 KB
Referenced Files
None
Subscribers
None

View Options

diff --git a/RELEASE-NOTES-1.44 b/RELEASE-NOTES-1.44
index 8e78ca6a64e..db9b34e8f7b 100644
--- a/RELEASE-NOTES-1.44
+++ b/RELEASE-NOTES-1.44
@@ -650,6 +650,7 @@ because of Phabricator reports.
- Xml::buildTable() – use OOUI or Codex widgets instead
- Xml::buildTableRow() – use OOUI or Codex widgets instead
- Xml::textarea() – use Html::element() instead
+ - Xml::submitButton() – use Html::submitButton() instead
* BlockUtils and BlockUtilsFactory is now deprecated. Use BlockTargetFactory
and CrossWikiBlockTargetFactory.
* RenameuserSQL::rename has been deprecated and should be replaced with
diff --git a/includes/xml/Xml.php b/includes/xml/Xml.php
index 4f2056f46fb..e328f45a43c 100644
--- a/includes/xml/Xml.php
+++ b/includes/xml/Xml.php
@@ -500,9 +500,11 @@ class Xml {
* @param array $attribs Optional custom attributes
* @return string HTML
*
- * @deprecated since 1.42, use {@see Html::submitButton} instead
+ * @deprecated since 1.42, use {@see Html::submitButton} instead; emitting deprecation warnings since 1.44
*/
public static function submitButton( $value, $attribs = [] ) {
+ wfDeprecated( __METHOD__, '1.42' );
+
$attribs += [
'type' => 'submit',
'value' => $value,
@@ -841,7 +843,13 @@ class Xml {
$form .= self::openElement( 'tr' );
$form .= self::tags( 'td', [], '' );
$form .= self::openElement( 'td', [ 'class' => 'mw-submit' ] )
- . self::submitButton( wfMessage( $submitLabel )->text(), $submitAttribs )
+ . Html::element(
+ 'input',
+ $submitAttribs + [
+ 'type' => 'submit',
+ 'value' => wfMessage( $submitLabel )->text(),
+ ]
+ )
. self::closeElement( 'td' );
$form .= self::closeElement( 'tr' );
}

File Metadata

Mime Type
text/x-diff
Expires
Sat, Jul 5, 5:32 AM (11 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
227507
Default Alt Text
(1 KB)

Event Timeline