Page MenuHomePhorge
Files F585157

No OneTemporary
Actions

Size
1 KB
Referenced Files
None
Subscribers
None

View Options

diff --git a/RELEASE-NOTES-1.44 b/RELEASE-NOTES-1.44
index 14594f60ef5..d374ee35de7 100644
--- a/RELEASE-NOTES-1.44
+++ b/RELEASE-NOTES-1.44
@@ -667,6 +667,7 @@ because of Phabricator reports.
- Xml::submitButton() – use Html::submitButton() instead
- Xml::check() – use Html::check() instead
- Xml::radio() – use Html::radio() instead
+ - Xml::input() – use Html::input() instead
* BlockUtils and BlockUtilsFactory is now deprecated. Use BlockTargetFactory
and CrossWikiBlockTargetFactory.
* RenameuserSQL::rename has been deprecated and should be replaced with
diff --git a/includes/xml/Xml.php b/includes/xml/Xml.php
index 01872182bf9..7c195157918 100644
--- a/includes/xml/Xml.php
+++ b/includes/xml/Xml.php
@@ -304,9 +304,11 @@ class Xml {
* @param array $attribs Other attributes
* @return string HTML
*
- * @deprecated since 1.42, use {@see Html::input} instead
+ * @deprecated since 1.42, use {@see Html::input} instead; emitting warnings since 1.44
*/
public static function input( $name, $size = false, $value = false, $attribs = [] ) {
+ wfDeprecated( __METHOD__, '1.42' );
+
$attributes = [ 'name' => $name ];
if ( $size ) {
diff --git a/tests/phpunit/includes/xml/XmlTest.php b/tests/phpunit/includes/xml/XmlTest.php
index 1b99bc7eec3..7d354536ad4 100644
--- a/tests/phpunit/includes/xml/XmlTest.php
+++ b/tests/phpunit/includes/xml/XmlTest.php
@@ -70,6 +70,7 @@ class XmlTest extends MediaWikiIntegrationTestCase {
}
public function testElementInputCanHaveAValueOfZero() {
+ $this->hideDeprecated( Xml::class . '::input' );
$this->assertEquals(
'<input name="name" value="0" />',
Xml::input( 'name', false, 0 ),

File Metadata

Mime Type
text/x-diff
Expires
Sat, Jul 5, 5:32 AM (11 h, 54 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
227570
Default Alt Text
(1 KB)

Event Timeline