Page MenuHomePhorge
Create Task
Maniphest T115

Bug with CheckUser extension
Closed, ResolvedPublic
Actions

Description

Problem: When getting users for an IP address or IP address range, this occurs:

[5a54dbf916d70d373189953f] /wiki/Special:CheckUser InvalidArgumentException: Cannot create a user with no name, no ID, and no actor ID

Backtrace:

from /var/www/html/includes/user/UserFactory.php(263)
#0 /var/www/html/includes/user/UserFactory.php(199): MediaWiki\User\UserFactory->newFromAnyId()
#1 /var/www/html/extensions/CheckUser/src/CheckUser/Pagers/CheckUserGetUsersPager.php(193): MediaWiki\User\UserFactory->newFromUserIdentity()
#2 /var/www/html/extensions/CheckUser/src/CheckUser/Pagers/CheckUserGetUsersPager.php(167): MediaWiki\CheckUser\CheckUser\Pagers\CheckUserGetUsersPager->formatUserRow()
#3 /var/www/html/extensions/CheckUser/src/CheckUser/SpecialCheckUser.php(435): MediaWiki\CheckUser\CheckUser\Pagers\CheckUserGetUsersPager->getBody()
#4 /var/www/html/includes/specialpage/SpecialPage.php(719): MediaWiki\CheckUser\CheckUser\SpecialCheckUser->execute()
#5 /var/www/html/includes/specialpage/SpecialPageFactory.php(1669): MediaWiki\SpecialPage\SpecialPage->run()
#6 /var/www/html/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#7 /var/www/html/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#8 /var/www/html/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#9 /var/www/html/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#10 {main}

[95f3da58548e2a9b80b5b14d] /wiki/Special:CheckUser TypeError: MediaWiki\User\UserIdentityValue::__construct(): Argument #2 ($name) must be of type string, null given, called in /var/www/html/extensions/CheckUser/src/CheckUser/Pagers/CheckUserGetActionsPager.php on line 686

When getting actions, this error occurs:

Backtrace:

from /var/www/html/includes/user/UserIdentityValue.php(60)
#0 /var/www/html/extensions/CheckUser/src/CheckUser/Pagers/CheckUserGetActionsPager.php(686): MediaWiki\User\UserIdentityValue->__construct()
#1 /var/www/html/includes/pager/IndexPager.php(297): MediaWiki\CheckUser\CheckUser\Pagers\CheckUserGetActionsPager->preprocessResults()
#2 /var/www/html/includes/pager/IndexPager.php(571): MediaWiki\Pager\IndexPager->doQuery()
#3 /var/www/html/extensions/CheckUser/src/CheckUser/SpecialCheckUser.php(408): MediaWiki\Pager\IndexPager->getBody()
#4 /var/www/html/includes/specialpage/SpecialPage.php(719): MediaWiki\CheckUser\CheckUser\SpecialCheckUser->execute()
#5 /var/www/html/includes/specialpage/SpecialPageFactory.php(1669): MediaWiki\SpecialPage\SpecialPage->run()
#6 /var/www/html/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#7 /var/www/html/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#8 /var/www/html/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#9 /var/www/html/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#10 {main}

Details

Security
None

Related Objects

Event Timeline

Dmehus created this task.Oct 21 2024, 12:03 PM
Herald added subscribers: Justarandomamerican, MacFan4000. · View Herald TranscriptOct 21 2024, 12:03 PM
Dmehus updated the task description. (Show Details)Oct 21 2024, 12:05 PM
Justarandomamerican signed these changes with MFA.Oct 21 2024, 12:22 PM
Justarandomamerican triaged this task as Low priority.

Problem is localized to the IP and account of Nexovia.

Dmehus added a comment.Oct 21 2024, 12:27 PM

Weird, for a specific IP address. Any idea what's causing this? Is there an upstream ticket on Wikimedia Phabricator?

Justarandomamerican added a comment.EditedOct 21 2024, 12:29 PM

I think it might be a bug in the UserMerge extension, which was previously used to merge Nexovia and The woman into one, and delete Nexovia.

Harvici subscribed.Oct 21 2024, 12:45 PM

@Justarandomamerican I believe you should update the database, as it is possible that some references to the old user were not updated properly in the database

Dmehus added a comment.Oct 22 2024, 2:15 AM
In T115#2086, @Harvici wrote:

@Justarandomamerican I believe you should update the database, as it is possible that some references to the old user were not updated properly in the database

Ah, good thought.

Dmehus added a comment.Oct 22 2024, 2:16 AM
In T115#2084, @Justarandomamerican wrote:

I think it might be a bug in the UserMerge extension, which was previously used to merge Nexovia and The woman into one, and delete Nexovia.

Ah, that might do it, since UserMerge isn't used much anymore; it may not be compatible with the latest iterations of CheckUser.

I didn't even know we still had UserMerge on Test Wiki. I do like it for merging multiple vandal accounts into one.

Zippybonzo subscribed.Nov 19 2024, 1:08 PM

Personally I think UserMerge causes more issues than it fixes, and should ideally be removed because it's buggy and old.

Harvici added a comment.Nov 26 2024, 6:58 AM

@Justarandomamerican Any updates ?

Justarandomamerican added a comment.Nov 26 2024, 5:10 PM
In T115#2103, @Zippybonzo wrote:

Personally I think UserMerge causes more issues than it fixes, and should ideally be removed because it's buggy and old.

I would agree. Will remove.. soon™

Justarandomamerican added a comment.Dec 17 2024, 7:53 PM

Apologies folks, I've been busy. I will remove it whenever I get a chance.

Harvici added a comment.Fri, Jan 17, 5:45 PM

Just checking in.....

MacFan4000 closed this task as Invalid.Thu, Jan 23, 6:36 PM

I'm not getting any error when checking IPs for Nexovia, though it comes back with no results.

X reopened this task as Open.EditedThu, Jan 23, 7:45 PM
X subscribed.

The reason no error is popping up, I assume, is because the time period for Nexovia's data has passed and it is no longer stored.

However, per other comments in this ticket, the UserMerge extension should be removed as it causes CU errors.

In T115#2105, @Justarandomamerican wrote:
In T115#2103, @Zippybonzo wrote:

Personally I think UserMerge causes more issues than it fixes, and should ideally be removed because it's buggy and old.

I would agree. Will remove.. soon™

Justarandomamerican mentioned this in rMW83e63cbd0940: Remove UserMerge (T115).Sat, Jan 25, 10:27 PM
MacFan4000 closed this task as Resolved.Sun, Jan 26, 2:52 AM
MacFan4000 claimed this task.

UserMerge has been removed.