HomePhorge

Revision,Storage: Widen `@covers` tags in tests

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

Revision,Storage: Widen @covers tags in tests

Given all called same-class methods are de-facto and liberally claimed,
and that we keep the coverage limited to the subject class, it maintains
the spirit and intent by listing the class as a whole instead.

PHPUnit offers a more precise tool when you need it (i.e. when testing
legacy monster/god classes), but for well-written code, the
class-wide tag is exactly what you want.

We lose useful coverage and waste valuable time on keeping tags
accurate through refactors, especially private functions (or worse,
forget to update it).
Tracking tiny per-method details wastes time in realizing (and
fixing) when people inevitably don't keep them in sync, and time
lost in finding uncovered code to write tests to realize it was
already covered but "not yet claimed".

Ref https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen

Change-Id: If90fc5285a067ec8f706d87b2ba1ae85020e2ba0

Details

Provenance
Timo TijhofAuthored on Aug 30 2024, 2:18 AM
KrinkleCommitted on Aug 30 2024, 4:23 AM

Event Timeline

Krinkle <krinkle@fastmail.com> committed rMW311b2d0e986b: Revision,Storage: Widen `@covers` tags in tests (authored by Timo Tijhof <krinkle@fastmail.com>).Aug 30 2024, 4:23 AM

Commit No Longer Exists

This commit no longer exists in the repository.