HomePhorge

page: Widen `@covers` annotations in WikiPageDbTest

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

page: Widen @covers annotations in WikiPageDbTest

We lose useful coverage and spend valuable time keeping these tags
accurate through refactors (or worse, forget to do so).

I've audited each test to confirm it is a general test of the
subject class, where adding any called methods would be an accepted
change, thus widening it is merely a no-op that clarifies intent
and reduces maintenance. I am not disabling the "only track coverage
of specified subject" benefits, nor am I claiming coverage in
in classes outside the subject under test.

Tracking tiny details per-method wastes time in keeping references
in sync during refactors, time to realize (and fix) when people
inevitably don't keep them in sync, time lost in finding uncovered
code to write tests for only to realize it was already covered but
not yet claimed, etc.

https: //gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:%2522Widen%2522
Change-Id: I8d8a185e8bcdf854ddd4fd3930d3bd6268f38083

Details

Provenance
Timo TijhofAuthored on Nov 17 2023, 10:09 PM
KrinkleCommitted on Nov 29 2023, 2:54 AM

Event Timeline

Krinkle <krinkle@fastmail.com> committed rMWba30980a35cf: page: Widen `@covers` annotations in WikiPageDbTest (authored by Timo Tijhof <krinkle@fastmail.com>).Nov 29 2023, 2:54 AM

Commit No Longer Exists

This commit no longer exists in the repository.